Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CREATE-PLAY docs #634

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Update CREATE-PLAY docs #634

merged 2 commits into from
Oct 8, 2022

Conversation

Susmita-Dey
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Updated the docs for npm install error.

Fixes #591

Type of change

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 7, 2022

@Susmita-Dey is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@Susmita-Dey Susmita-Dey marked this pull request as ready for review October 7, 2022 07:49
CREATE-PLAY.md Show resolved Hide resolved
@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 8, 2022
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Susmita-Dey Looks good. Thanks for adding the help text.

@vercel
Copy link

vercel bot commented Oct 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 8, 2022 at 3:04AM (UTC)

@atapas
Copy link
Member

atapas commented Oct 8, 2022

@all-contributors please add @Susmita-Dey for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @Susmita-Dey! 🎉

@Susmita-Dey Susmita-Dey deleted the update-doc-npm-error branch October 8, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: npm install error
2 participants