-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Play: Inspirational Quotes #609
Conversation
@atapas @koustov I need little help with the last pending ToDo. I provided a cover link while creating the play. But that seems to be invalid. Now I want to use |
@muzaffar640 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@muzaffar640 Done, please check and confirm. |
Thanks, @atapas for the quick reply. Yes, it has been updated. I have opened the PR for review. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muzaffar640 Thanks for the play!
Provided review comments. Please take care.
box-sizing: border-box; | ||
font-family: "Roboto", sans-serif; | ||
} | ||
.card { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment for all the styles..
.inpirational-quotes-play .card
for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muzaffar640 This comment is pending.
fed353a
to
b29caa5
Compare
thanks, @atapas for the review. Addressed all your comments. Review Ready. |
b29caa5
to
ecabff3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few changes.
@atapas , PR is ready to merge. |
@muzaffar640 , Can you address the pending comments? |
@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed. |
@muzaffar640 , This one is pending can you address it? |
@muzaffar640 Can you please take a look? It's very close to merge. |
@atapas #609 (comment) has already been resolve. It looks like it has not but if you click on the page you will see the updated code. |
Description
This typescript app contains motivational quotes. This app has over 250 carefully chosen quotes to motivate users. I did not produce quotations using any API. I have hand-picked these relevant quotes.
Fixes # 608
Type of change
New Play
How Has This Been Tested?
This has been tested locally
ToDo
Checklist:
Screenshot