Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Play: Inspirational Quotes #609

Merged
merged 22 commits into from
Dec 2, 2022

Conversation

muzaffar640
Copy link
Contributor

@muzaffar640 muzaffar640 commented Oct 5, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This typescript app contains motivational quotes. This app has over 250 carefully chosen quotes to motivate users. I did not produce quotations using any API. I have hand-picked these relevant quotes.

Fixes # 608

Type of change

New Play

How Has This Been Tested?

This has been tested locally

ToDo

  • Remove play cover metadata which was provided initially.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot

Screenshot 2022-10-05 at 12 13 18 PM
Screenshot 2022-10-05 at 11 49 44 AM

@muzaffar640
Copy link
Contributor Author

muzaffar640 commented Oct 5, 2022

@atapas @koustov I need little help with the last pending ToDo. I provided a cover link while creating the play. But that seems to be invalid. Now I want to use cover.png. Can you please remove the metadata from the backend? I can able find a way to edit the metadata. Let me know if you need any information.

@vercel
Copy link

vercel bot commented Oct 5, 2022

@muzaffar640 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 4:47AM (UTC)

@atapas
Copy link
Member

atapas commented Oct 5, 2022

@muzaffar640 Done, please check and confirm.

@muzaffar640
Copy link
Contributor Author

@muzaffar640 Done, please check and confirm.

Thanks, @atapas for the quick reply. Yes, it has been updated. I have opened the PR for review. 🚀

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muzaffar640 Thanks for the play!

Provided review comments. Please take care.

src/plays/inspirational-quotes/Readme.md Outdated Show resolved Hide resolved
src/plays/inspirational-quotes/card.css Outdated Show resolved Hide resolved
box-sizing: border-box;
font-family: "Roboto", sans-serif;
}
.card {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment for all the styles..

.inpirational-quotes-play .card

for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muzaffar640 This comment is pending.

@muzaffar640
Copy link
Contributor Author

thanks, @atapas for the review. Addressed all your comments. Review Ready.

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few changes.

@Sachin-chaurasiya
Copy link
Member

@atapas , PR is ready to merge.

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Oct 30, 2022

@muzaffar640 , Can you address the pending comments?

@muzaffar640
Copy link
Contributor Author

@muzaffar640 , Can you address the pending comments?

@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.

@Sachin-chaurasiya
Copy link
Member

@muzaffar640 , Can you address the pending comments?

@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.

@muzaffar640 , This one is pending can you address it?
#609 (comment)

@atapas
Copy link
Member

atapas commented Nov 9, 2022

@muzaffar640 , Can you address the pending comments?

@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.

@muzaffar640 , This one is pending can you address it? #609 (comment)

@muzaffar640 Can you please take a look? It's very close to merge.

@muzaffar640
Copy link
Contributor Author

@muzaffar640 , Can you address the pending comments?

@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.

@muzaffar640 , This one is pending can you address it? #609 (comment)

@muzaffar640 Can you please take a look? It's very close to merge.

@atapas #609 (comment) has already been resolve. It looks like it has not but if you click on the page you will see the updated code.

@atapas atapas merged commit 0af8c2e into reactplay:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Inspirational Quotes
4 participants