-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support to select multiple filters #595
Conversation
@supminn is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
…n/react-play into issue-24-multiple-filters
Hey @koustov Please take a look. |
Hi @koustov |
@supminn is it ready to be reviewed? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
A couple of notes
- Cypress is failing with some timeout. Until that one is passed, I will not be able to merge
- @supminn It would be nice if we give a search/filter box for creator dropdown. Can you create an issue?
Description
Previously, only a combination of 1 level, 1 creator, and 1 Tag was available at a time.
I have implemented the option to select multiple values of each combination. (Screenshot attached below)
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
Screenshots