Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to select multiple filters #595

Merged
merged 13 commits into from
Oct 31, 2022
Merged

feat: support to select multiple filters #595

merged 13 commits into from
Oct 31, 2022

Conversation

supminn
Copy link
Contributor

@supminn supminn commented Oct 3, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Previously, only a combination of 1 level, 1 creator, and 1 Tag was available at a time.
I have implemented the option to select multiple values of each combination. (Screenshot attached below)

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots

image
image

@vercel
Copy link

vercel bot commented Oct 3, 2022

@supminn is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@atapas
Copy link
Member

atapas commented Oct 8, 2022

Hey @koustov Please take a look.

@koustov
Copy link
Member

koustov commented Oct 11, 2022

Hey @koustov Please take a look.

@supminn do you still have the issue? I have already published the package as I mentioned in this pr

@supminn
Copy link
Contributor Author

supminn commented Oct 12, 2022

Hey @koustov Please take a look.

@supminn do you still have the issue? I have already published the package as I mentioned in this pr

Hi @koustov
I didn't get a chance to work on this for the last 2-3 days. I'll work on it and update you by tomorrow EOD.

@supminn
Copy link
Contributor Author

supminn commented Oct 16, 2022

Hi @koustov
I am facing a few blockers while working with the latest changes. I have mentioned the details on discord.
Could you please let me know a suitable time to connect in this regard?

@koustov
Copy link
Member

koustov commented Oct 19, 2022

@supminn is it ready to be reviewed?

@supminn
Copy link
Contributor Author

supminn commented Oct 20, 2022

@supminn is it ready to be reviewed?

Yes @koustov, could you please review the changes.
I had dropped a message on #pr_review in discord.

@atapas atapas added the koustov label Oct 29, 2022
@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 8:35AM (UTC)

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

A couple of notes

  1. Cypress is failing with some timeout. Until that one is passed, I will not be able to merge
  2. @supminn It would be nice if we give a search/filter box for creator dropdown. Can you create an issue?

@koustov koustov merged commit bacf597 into reactplay:main Oct 31, 2022
@koustov koustov added the hacktoberfest-accepted hacktoberfest-accepted label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants