Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit event modal pop-up on save click #587

Merged

Conversation

muzaffar640
Copy link
Contributor

@muzaffar640 muzaffar640 commented Oct 2, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

I have added onCancel() if the event is true. So when you edit an event and click on Save, it will close the whole edit event modal.

Fixes #584

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Clicked on an "Event" on the calendar and then the Edit button
  2. Once done with Edit and click on the Save button.
  3. The whole modal is getting close.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshare

Screen.Recording.2022-10-02.at.8.06.59.PM.mov

@vercel
Copy link

vercel bot commented Oct 2, 2022

@muzaffar640 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@muzaffar640
Copy link
Contributor Author

Review Ready

@Sachin-chaurasiya
Copy link
Member

@muzaffar640 , Can you attach some screen recordings?

@muzaffar640
Copy link
Contributor Author

@muzaffar640 , Can you attach some screen recordings?

Thank you for the review @Sachin-chaurasiya , I have updated the comment with a screen recording.

@muzaffar640
Copy link
Contributor Author

Rebased and Review Ready

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vercel
Copy link

vercel bot commented Oct 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 9, 2022 at 5:02PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: On Clicking "Save" the edit event modal not closing.
3 participants