Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev jokes js to ts #581

Merged
merged 9 commits into from
Oct 5, 2022
Merged

Dev jokes js to ts #581

merged 9 commits into from
Oct 5, 2022

Conversation

yung-coder
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Here i have tried to change dev jokes from JavaScript to typescript .

Fixes #563

Type of change

  • [ ✅] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

It has been tested by me in my local system for all edge cases.

Checklist:

  • [ ✅] I have performed a self-review of my own code
  • [✅ ] I have commented my code, particularly in hard-to-understand areas
  • [✅ ] I have made corresponding changes to the documentation
  • [✅ ] My changes generate no new warnings
  • [ ✅] I have added tests that prove my fix is effective or that my feature works
  • [✅ ] New and existing unit tests pass locally with my changes
  • [ ✅] Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 8:52AM (UTC)

@yung-coder
Copy link
Contributor Author

hey @koustov please give it a look ...

@Sachin-chaurasiya
Copy link
Member

@yung-coder , Can you add the meaningful title for the PR?

@yung-coder yung-coder changed the title Issue 563 Dev jokes js to ts Oct 1, 2022
@yung-coder
Copy link
Contributor Author

hey @Sachin-chaurasiya updated give it a look

@yung-coder
Copy link
Contributor Author

Done

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested minor change

@yung-coder
Copy link
Contributor Author

Should I change the name of interface @Sachin-chaurasiya ..?

@Sachin-chaurasiya
Copy link
Member

Should I change the name of interface @Sachin-chaurasiya ..?

@yung-coder , Yes, please see the suggested changes.

@yung-coder
Copy link
Contributor Author

done @Sachin-chaurasiya

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments.

@yung-coder
Copy link
Contributor Author

done @Sachin-chaurasiya

@yung-coder
Copy link
Contributor Author

done @Sachin-chaurasiya i think its all good now

@yung-coder
Copy link
Contributor Author

hey @atapas can you review this ..?

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yung-coder for converting the JS play to TS. The implementation looks good tome. Approving. After merging, I need to change the language to TS in db, will do that.

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 5, 2022
@atapas atapas merged commit 3f77bf2 into main Oct 5, 2022
@atapas atapas deleted the issue-563 branch October 5, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Dev jokes javascript to typescript
3 participants