Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/semantic landmarks #579

Merged
merged 7 commits into from
Oct 14, 2022
Merged

Conversation

EmmaDawsonDev
Copy link
Contributor

@EmmaDawsonDev EmmaDawsonDev commented Oct 1, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #566

I changed divs to main tags to make the code more semantic and accessible.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Since there are no tests I just checked visually that everything still looks and works the same.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 1, 2022

@EmmaDawsonDev is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @EmmaDawsonDev.

@vercel
Copy link

vercel bot commented Oct 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 2:29PM (UTC)

@EmmaDawsonDev
Copy link
Contributor Author

Anything else you want me to do on this?

@atapas
Copy link
Member

atapas commented Oct 14, 2022

@EmmaDawsonDev I can merge it sooner the merge conflicts are resolved!

@EmmaDawsonDev
Copy link
Contributor Author

Merge conflict is solved. I'd appreciate it if this isn't left for several more days to accrue more conflicts :)

@atapas
Copy link
Member

atapas commented Oct 14, 2022

Merge conflict is solved. I'd appreciate it if this isn't left for several more days to accrue more conflicts :)

I promise it won't. It's going to go straight to main the moment it passes my test today! Stay tuned 👀

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaDawsonDev Thank you for your contributions to making it better.

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 14, 2022
@atapas atapas merged commit 4a931fb into reactplay:main Oct 14, 2022
@atapas
Copy link
Member

atapas commented Oct 14, 2022

@all-contributors please add @EmmaDawsonDev for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @EmmaDawsonDev! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Missing semantic html landmarks
4 participants