Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the z-index of .app-home-body-content class #569

Merged
merged 6 commits into from
Oct 5, 2022

Conversation

yash91989201
Copy link
Contributor

@yash91989201 yash91989201 commented Sep 26, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Changed the z-index value of .app-home-body-content class to 5 so that it doesnot clash with sidebar z-index value and causes a
content overlap. I changed the value to 5 but not 1 because of an image that is present along with .app-home-body-content class as its sibling
Fixes #568

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Sep 26, 2022

@yash91989201 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 2:56AM (UTC)

@atapas
Copy link
Member

atapas commented Sep 27, 2022

@yash91989201 I have marked the PR for Hacktoberfest.. Make sure you register for the event... Follow the Forum discussion on our discord.

Coming back the PR, the Tests are failing, please take a look.

@yash91989201
Copy link
Contributor Author

Sure I'll look into it

@atapas
Copy link
Member

atapas commented Sep 27, 2022

Sure I'll look into it

Test Passed now.

@yash91989201
Copy link
Contributor Author

Please wait until october 1 for merging this pr, because then only it will count under my hacktoberfest contribution

@atapas
Copy link
Member

atapas commented Sep 27, 2022

Yes sir, in my radar 😀

@Sachin-chaurasiya
Copy link
Member

@yash91989201, Can you fix the formatting as the entire CSS file content is getting changed?

@yash91989201
Copy link
Contributor Author

yash91989201 commented Oct 1, 2022

Done, I turned the formatting off and then I changed the z-index value for the final time and I commit the changes. Are there any errors now ??

@Sachin-chaurasiya
Copy link
Member

Done, I turned the formatting off and then I changed the z-index value for the final time and I commit the changes. Are there any errors now ??

I will check and let you know.

@Sachin-chaurasiya
Copy link
Member

@yash91989201 , Still there is a formatting issue.

image

@yash91989201
Copy link
Contributor Author

yash91989201 commented Oct 2, 2022

Okay, I'll fix the issue this time

@yash91989201
Copy link
Contributor Author

Everything fixed , now there will be no problem in merging (i hope so :) ) .

@atapas
Copy link
Member

atapas commented Oct 5, 2022

Hi @Sachin-chaurasiya

Could you please approve this PR if all is done from your end?

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good to me. Accepting.

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 5, 2022
@atapas
Copy link
Member

atapas commented Oct 5, 2022

@yash91989201 Thanks for your contribution. The next step is socialising your contribution and getting started with the next issue! Keep contributing.

@atapas atapas merged commit c389bd1 into reactplay:main Oct 5, 2022
@atapas
Copy link
Member

atapas commented Oct 5, 2022

@all-contributors please add @yash91989201 for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @yash91989201! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Content overlap on sidebar due to same z-index value
3 participants