-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the z-index of .app-home-body-content class #569
Conversation
@yash91989201 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@yash91989201 I have marked the PR for Hacktoberfest.. Make sure you register for the event... Follow the Forum discussion on our discord. Coming back the PR, the Tests are failing, please take a look. |
Sure I'll look into it |
Test Passed now. |
Please wait until october 1 for merging this pr, because then only it will count under my hacktoberfest contribution |
Yes sir, in my radar 😀 |
@yash91989201, Can you fix the formatting as the entire CSS file content is getting changed? |
ff3b4ea
to
cbe84e2
Compare
Done, I turned the formatting off and then I changed the z-index value for the final time and I commit the changes. Are there any errors now ?? |
I will check and let you know. |
@yash91989201 , Still there is a formatting issue. |
Okay, I'll fix the issue this time |
Everything fixed , now there will be no problem in merging (i hope so :) ) . |
Could you please approve this PR if all is done from your end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are looking good to me. Accepting.
@yash91989201 Thanks for your contribution. The next step is socialising your contribution and getting started with the next issue! Keep contributing. |
@all-contributors please add @yash91989201 for Code |
I've put up a pull request to add @yash91989201! 🎉 |
Description
Changed the z-index value of .app-home-body-content class to 5 so that it doesnot clash with sidebar z-index value and causes a
content overlap. I changed the value to 5 but not 1 because of an image that is present along with .app-home-body-content class as its sibling
Fixes #568
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: