Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 408 rename readme for qr code generator #409

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

koustov
Copy link
Member

@koustov koustov commented Jul 22, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #408

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@koustov koustov requested a review from atapas as a code owner July 22, 2022 19:48
@vercel
Copy link

vercel bot commented Jul 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 7:51PM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine but the project doesn't have a Readme file. That needs to be fixed separately.

@murtuzaalisurti

@atapas atapas merged commit b926c7f into main Jul 23, 2022
@atapas atapas deleted the Issue-408-rename-readme-for-qr-code-generator branch July 23, 2022 04:39
@murtuzaalisurti
Copy link
Member

murtuzaalisurti commented Jul 23, 2022

I added the readme file when I made a PR. I don't know why it's not evident, need to check.

@atapas
Copy link
Member

atapas commented Jul 23, 2022

I added the readme file when I made a PR. I don't know why it's not evident, need to check.

It's fine now.

@murtuzaalisurti
Copy link
Member

is it fixed or do I need to?

__
sema-logo  Summary: ❓ I have a question  |  Tags: Not reusable

@atapas
Copy link
Member

atapas commented Jul 23, 2022

is it fixed or do I need to?

__ sema-logo sema-logo  Summary: ❓ I have a question  |  Tags: Not reusable

Fixed. Check one on prod

@murtuzaalisurti
Copy link
Member

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: QR Code Generator : readme link is broken
3 participants