Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new play along with some fixes in new workflow #396

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

murtuzaalisurti
Copy link
Member

Description

Added a new play and some fixes to the new workflow!

Fixes #175

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Works great!

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 4:10PM (UTC)

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koustov
Copy link
Member

koustov commented Jul 21, 2022

To all reviewers
This PR has been targetted for Issue-369-Create-play-workflow branch, not main

Once this PR is merged, the create work, I will work on some warning removal

@atapas atapas linked an issue Jul 22, 2022 that may be closed by this pull request
@atapas atapas merged commit 5641437 into Issue-369-Create-play-workflow Jul 22, 2022
@atapas atapas deleted the Issue-175-add-play branch July 22, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: QR Code Generator
3 participants