Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some padding to the footer #387

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Add some padding to the footer #387

merged 2 commits into from
Jul 19, 2022

Conversation

6km
Copy link
Member

@6km 6km commented Jul 19, 2022

Description

I have added some padding to the footer

Fixes #384

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@6km 6km requested review from atapas and koustov as code owners July 19, 2022 11:23
@vercel
Copy link

vercel bot commented Jul 19, 2022

@6km is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 2:03PM (UTC)

@Angryman18
Copy link
Member

looks better. let us make the text at center as it aprears at center on big screen.

@6km
Copy link
Member Author

6km commented Jul 19, 2022

let us make the text at center as it aprears at center on big screen.

@Angryman18 done, can you re-review please?

@Angryman18
Copy link
Member

LGTM

@atapas atapas merged commit d894895 into reactplay:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer mobile view needs a little improvement
3 participants