Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added A Home page section for Twitter mentions #377

Merged
merged 15 commits into from
Jul 22, 2022

Conversation

Anirban-1490
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added a section on the home page that brings the mentions we get for the ReactPlayIO Twitter handle. It's using the Twitter API but instead of dynamically updating it , we just have 10 static tweet ids (twitter only provides tweet upto previous 7 days only) and using react-twitter-widget i am showing this to the website as an embeded.

Fixes #134

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
2022.07.14-17.26.mp4

@atapas @koustov sorry, i had to create a new PR as i was not able to push new changes to the old PR. Check this one

@vercel
Copy link

vercel bot commented Jul 15, 2022

@Anirban-1490 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 1:11PM (UTC)

src/common/home/Home.jsx Outdated Show resolved Hide resolved
@nirmalkc
Copy link
Collaborator

Here is the mockup of how the final outcome should be.

image

For the background color of the section, please use this CSS variable --color-neutral-20.

@nirmalkc
Copy link
Collaborator

Here is the mockup of how the final outcome should be.

image

For the background color of the section, please use this CSS variable --color-neutral-20.

In .home-tweets class, please add the background color. And apply the same title style like how it is used in the other sections.

@Anirban-1490
Copy link
Contributor Author

Here is the mockup of how the final outcome should be.
image
For the background color of the section, please use this CSS variable --color-neutral-20.

In .home-tweets class, please add the background color. And apply the same title style like how it is used in the other sections.

and what about the background picture ?

@atapas atapas requested a review from nirmalkc July 22, 2022 02:44
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anirban-1490 2 comments

plus remove the src/images/group-1825510_1280.jpg file as we do not need it anymore.

src/common/home/Home.jsx Outdated Show resolved Hide resolved
src/common/home/Home.jsx Outdated Show resolved Hide resolved
src/common/home/home.css Outdated Show resolved Hide resolved
src/common/home/home.css Outdated Show resolved Hide resolved
src/common/home/home.css Outdated Show resolved Hide resolved
src/common/home/home.css Outdated Show resolved Hide resolved
src/common/home/home.css Show resolved Hide resolved
@Anirban-1490
Copy link
Contributor Author

@atapas @nirmalkc did all the changes .check it now

@@ -1,4 +1,4 @@
import { useState, useEffect, useContext } from "react";
import { useState, useEffect, useContext} from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting it. COuld you please retain the space before the closing } as it was before?

@Anirban-1490

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting it. COuld you please retain the space before the closing } as it was before?

@Anirban-1490

ok

nirmalkc
nirmalkc previously approved these changes Jul 22, 2022
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atapas atapas merged commit f34f20c into reactplay:main Jul 22, 2022
@atapas
Copy link
Member

atapas commented Jul 22, 2022

@all-contributors please add @Anirban-1490 for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @Anirban-1490! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Create a Home page section for Twitter mentions
3 participants