simple live chat #258
Merged
simple live chat #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
firebase config has to change with official react-play's firebase. and anyone feel free to make changes and look things better. |
Programming-School-Pro-Coding
suggested changes
Jun 1, 2022
|
@koustov Can you please review this one? |
atapas
requested changes
Jun 5, 2022
|
@Angryman18 I am reviewing it now. Also please resolve all the open items. |
koustov
requested changes
Jun 5, 2022
koustov
requested changes
Jun 5, 2022
|
@Angryman18 We have made the changes to support TailwindCSS. Please pull the latest and test your UI flow. |
koustov
previously approved these changes
Jun 8, 2022
There was a problem hiding this comment.
I am unblocking this PR as all (but one ) of my concerns are addressed and the code looks perfect to me. However, following needs to be fixed before we hit the "merge" button
- A small change for .env file
- Preview build is failing. @atapas could you please check the reason for it.
atapas
reviewed
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: