Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 161 filter plays lang #182

Merged
merged 3 commits into from
May 16, 2022
Merged

Issue 161 filter plays lang #182

merged 3 commits into from
May 16, 2022

Conversation

atapas
Copy link
Member

@atapas atapas commented May 16, 2022

Description

This PR is created to add Language as one of the filter Criteria

Fixes # (issue) #161

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with a permutation and combination of filter Criteria.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented May 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 16, 2022 at 7:33AM (UTC)

@atapas atapas linked an issue May 16, 2022 that may be closed by this pull request
@atapas
Copy link
Member Author

atapas commented May 16, 2022

Hello @hasnainmakada-99

Could you please test the changes once and let me know if all is good? Here is the preview link: https://react-play-git-issue-161-filter-plays-lang-atapas.vercel.app/

@hasnainmakada-99
Copy link
Contributor

Yeah sure

@hasnainmakada-99
Copy link
Contributor

@atapas sir, do we have only one play in typescript ?

@atapas
Copy link
Member Author

atapas commented May 16, 2022

@atapas sir, do we have only one play in typescript ?

Yes, so far.

@hasnainmakada-99
Copy link
Contributor

Yes sir I've tested it multiple times and applied different condition cheks also, we're good to go 👍

Copy link
Contributor

@hasnainmakada-99 hasnainmakada-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good to go

@atapas atapas merged commit bfeba2d into main May 16, 2022
@atapas atapas deleted the issue-161-filter-plays-lang branch May 16, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Filter Plays by Language
2 participants