Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed : #1442 added instagram and linkedin icons to the footer #1446

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

Siddh744542
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

added the Instagram and Linkedin Icon to the footer and fixed to the extendedFooter file

Fixes #1442

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 89b85c2
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65cc4322e81c0400093d047c
😎 Deploy Preview https://deploy-preview-1446--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal
Copy link
Member

Hello @Siddh744542, one suggestion before submitting a PR: please ask for the assignment in the issue section. It helps to clarify and streamline the process.

@Siddh744542
Copy link
Contributor Author

@priyankarpal sorry for the inconvenience, will ask before making PR in the future.

@Siddh744542 Siddh744542 changed the title fiexed : #1442 added instargam and linkedin icons to the footer fixed : #1442 added instargam and linkedin icons to the footer Feb 14, 2024
@priyankarpal priyankarpal merged commit 39e591e into reactplay:main Feb 14, 2024
@Siddh744542 Siddh744542 changed the title fixed : #1442 added instargam and linkedin icons to the footer fixed : #1442 added instagram and linkedin icons to the footer Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: add icons to the footer
3 participants