Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlapping footer layout of browse and create buttons #1425

Closed
wants to merge 7 commits into from
Closed

fix: overlapping footer layout of browse and create buttons #1425

wants to merge 7 commits into from

Conversation

clevercoderjoy
Copy link
Contributor

@clevercoderjoy clevercoderjoy commented Jan 22, 2024

Layout for create and browse button fix for small and medium-sized devices

Description

Fixed the overlapping create and browse buttons in the footer section for all small and medium-sized devices.

Fixes #1424

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • This has been tested with the Chrome dev tools responsive view.
  • Switched between different devices and checked that the UI was not breaking.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image
image

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 454d5f9
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65d045fcd3458b00080ac598
😎 Deploy Preview https://deploy-preview-1425--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal priyankarpal changed the title fix(footer): fixed the overlapping layout issue of browse and create … fix: overlapping footer layout of browse and create buttons Jan 23, 2024
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict error in this branch. Could you take steps to resolve it?

@priyankarpal priyankarpal added the changes required need to change some thing label Feb 9, 2024
@clevercoderjoy
Copy link
Contributor Author

There is a conflict error in this branch. Could you take steps to resolve it?

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are little bit issue
image

Screenshot_2024-02-11_10-16-47

@priyankarpal
Copy link
Member

now it's looking good ✨

priyankarpal
priyankarpal previously approved these changes Feb 13, 2024
@priyankarpal
Copy link
Member

@all-contributors add @clevercoderjoy for code

Copy link
Contributor

@priyankarpal

I've put up a pull request to add @clevercoderjoy! 🎉

@priyankarpal priyankarpal added ready to merge and removed changes required need to change some thing labels Feb 13, 2024
@priyankarpal priyankarpal added 🚧 status: blocked Blocked & therefore, not ready for work and removed ready to merge labels Feb 15, 2024
@priyankarpal priyankarpal removed the 🚧 status: blocked Blocked & therefore, not ready for work label Feb 17, 2024
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is messed up. Could you please create a separate PR?

@priyankarpal priyankarpal added the changes required need to change some thing label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: UI Issues in various small and medium sized devices
2 participants