Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved website accessibility, best practices, seo score to 100% #1421

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

janvi01
Copy link
Contributor

@janvi01 janvi01 commented Jan 4, 2024

Description

The PR aims to improve reactplay.io website accessibility, best practices, seo score to 100% by fixing the warnings/errors given by the lighthouse report.

some of the warnings fixed are-

  1. Elements must meet minimum color contrast ratio
  2. Links must have discernible text
  3. Links must have descriptive text

(PS: The pr doesn't improve the performance score, will be creating a separate PR for that)

Fixes #1419

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test locally and the Lighthouse score using google chrome devtools.

Screenshots or example output

Screenshot 2024-01-04 at 4 31 13 PM

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 461345f
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6597ad74bb7db0000862c096
😎 Deploy Preview https://deploy-preview-1421--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal priyankarpal added the changes required need to change some thing label Jan 5, 2024
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal added ready to merge and removed changes required need to change some thing labels Jan 6, 2024
@Sachin-chaurasiya Sachin-chaurasiya merged commit 8b144ed into reactplay:main Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: improve performance of reactplay.io
3 participants