Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: home component refactoring #1395

Merged
merged 12 commits into from
Nov 27, 2023
Merged

refactor: home component refactoring #1395

merged 12 commits into from
Nov 27, 2023

Conversation

kapoor-codes
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

The Home.jsx component in src/common/home is being refactored to enhance code readability and maintainability. The primary motivation is to improve developer experience by breaking down the component into smaller, more focused components. Folder Structure:

home/
┣ Contributors.jsx
┣ home.css
┣ Home.jsx
┣ HomeBanner.jsx
┣ HomeContent.jsx
┣ HomeContributors.jsx
┣ HomeFeatures.jsx
┣ HomeIdeas.jsx
┣ HomePlays.jsx
┣ HomeSponsors.jsx
┣ HomeTestimonials.jsx
┣ index.js
┗ Sponsors.jsx

Fixes #1384

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The refactored code has been thoroughly tested using the npm run build script to ensure its compatibility and reliability.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 8226c59
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6563a8e3c815a6000834a333
😎 Deploy Preview https://deploy-preview-1395--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@atapas
Copy link
Member

atapas commented Nov 24, 2023

@priyankarpal @Sachin-chaurasiya could you please review this?

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @v4xsh 🙌🏻,
Thanks for the contributions ✨

@priyankarpal
Copy link
Member

priyankarpal commented Nov 24, 2023

@priyankarpal @Sachin-chaurasiya could you please review this?

yeah let me check

@kapoor-codes
Copy link
Contributor Author

Great work @v4xsh 🙌🏻,
Thanks for the contributions ✨

No problem. Looking forward to contribute more @Sachin-chaurasiya :)

@priyankarpal
Copy link
Member

@v4xsh please look into it

Before After
image image

@priyankarpal priyankarpal added the changes required need to change some thing label Nov 24, 2023
@priyankarpal
Copy link
Member

@atapas please deploy & check

priyankarpal
priyankarpal previously approved these changes Nov 25, 2023
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@atapas atapas merged commit 7a0b46e into reactplay:main Nov 27, 2023
4 checks passed
@priyankarpal priyankarpal removed ready to merge changes required need to change some thing labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Turn the Home component into an more readable and maintainable one
6 participants