Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fix for favicon not visible on new tabs/plays #1387

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: bug fix for favicon not visible on new tabs/plays #1387

merged 1 commit into from
Nov 21, 2023

Conversation

kapoor-codes
Copy link
Contributor

@kapoor-codes kapoor-codes commented Nov 17, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This Pull Request addresses a specific issue in the React-Play repository where the favicon was not visible on new tabs during plays. The fix ensures proper visibility of the favicon in such scenarios, enhancing the overall user experience.

Fixes #1383

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually tested on multiple browsers to confirm the correct visibility of the favicon on new tabs during plays. Instructions: Clone, checkout, install dependencies, and start the application.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Chrome:
chrome

Edge:
edge

Firefox:
firefox

Copy link

netlify bot commented Nov 17, 2023

👷 Deploy request for reactplayio pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0d5fe20

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@atapas atapas merged commit 9b4760c into reactplay:main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Favicon not available on plays
4 participants