Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:button text in center (#1107) #1110 #1115

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

mohammedkharoda
Copy link
Contributor

@mohammedkharoda mohammedkharoda commented Apr 16, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Change the button text that align in the center and the issues is being address and fixes no depenices require just fixing the css

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Steps to reproduce the bug?

  • On Smaller screens:

Go to reactplay.io

  • On Bigger Screens:

Go to reactplay.io

  • Open console
  • Click on Device Toggle button

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

@vercel
Copy link

vercel bot commented Apr 16, 2023

@mohammedkharoda is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@atapas
Copy link
Member

atapas commented Apr 19, 2023

@mohammedkharoda Which issue are you working on? What's the issue number?

@mohammedkharoda
Copy link
Contributor Author

@atapas [fix:button text in center (#1107) #1110] I have work on this issues

@atapas atapas linked an issue Apr 19, 2023 that may be closed by this pull request
1 task
@atapas
Copy link
Member

atapas commented Apr 19, 2023

Thanks @mohammedkharoda

Have you checked this is prod? I see the button texts are already aligned center. Could you please confirm if that's the case?

image

@mohammedkharoda
Copy link
Contributor Author

@atapas It was not aligned in mobile responsive so I fix that and I have check it is working as expected after modification

@atapas
Copy link
Member

atapas commented Apr 19, 2023

@atapas It was not aligned in mobile responsive so I fix that and I have check it is working as expected after modification

Got it, Thanks!

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ✅ Ready (Inspect) Visit Preview 1 resolved Apr 19, 2023 1:03pm

@mohammedkharoda
Copy link
Contributor Author

@atapas The issues is slove so can you merge it 😁😁

@atapas atapas merged commit 00d58b8 into reactplay:main Apr 27, 2023
@atapas atapas mentioned this pull request Apr 27, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Button Text not centered
2 participants