Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed create-play; content available on docs site #1098

Merged
merged 7 commits into from
Apr 26, 2023

Conversation

supminn
Copy link
Contributor

@supminn supminn commented Apr 6, 2023

Description

The documentation on "How to create a play" has been moved from CREATE-PLAY.md to https://docs.reactplay.io/how-to-guides/how-to-create-play/
This PR contains the changes to remove the CREATE-PLAY.md file and change the references to point to the docs site.

Checklist:

  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ❌ Failed (Inspect) Apr 26, 2023 0:23am

src/common/header/HeaderNav.jsx Outdated Show resolved Hide resolved
src/constants/index.js Outdated Show resolved Hide resolved
@supminn
Copy link
Contributor Author

supminn commented Apr 16, 2023

Hi @atapas
I have incorporated the changes suggested by @Sachin-chaurasiya
Could you please provide your review?

@atapas
Copy link
Member

atapas commented Apr 19, 2023

@supminn there are a few conflicts to take care.

@supminn
Copy link
Contributor Author

supminn commented Apr 19, 2023

@supminn there are a few conflicts to take care.

Thanks, I have resolved them.

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @supminn 🙌🏻,
Thanks for the contributions ✨

@atapas
Copy link
Member

atapas commented Apr 26, 2023

LGTM

@atapas atapas merged commit 2022b92 into main Apr 26, 2023
@priyankarpal priyankarpal deleted the supminn/cleanup-doc branch October 16, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Documentation - Fixing reference to "How to create a play"
3 participants