Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-label & aria-expanded added to hamburger #1054

Merged
merged 6 commits into from
Apr 10, 2023

Conversation

shyamtawli
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

aria-label and aria-expanded added to hamburger menu.

Fixes # (issue)
#1041

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@vercel
Copy link

vercel bot commented Mar 10, 2023

@shyamtawli is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 1:22PM (UTC)

@atapas
Copy link
Member

atapas commented Mar 10, 2023

@shyamtawli

Please take care of the lint errors

image

Follow the instructions in the read me to how to format, lint, and lintfix it.

@shyamtawli
Copy link
Contributor Author

@atapas I didn't see that, now it is fixed. You can check now.

@shyamtawli
Copy link
Contributor Author

Hey @koustov Please review it.

@atapas atapas linked an issue Apr 10, 2023 that may be closed by this pull request
1 task
@atapas atapas merged commit 60b9c63 into reactplay:main Apr 10, 2023
@shyamtawli
Copy link
Contributor Author

Thanks @atapas for reviewing and merging it.

@shyamtawli shyamtawli deleted the aria-label/issue-1041 branch May 24, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: ally fix for hamberger menu
3 participants