Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: Expanding-card play's active card is too wide on small screen. #335

Closed
Deepak8717 opened this issue Jun 22, 2022 · 5 comments · Fixed by #337
Closed
Labels
bug Something isn't working

Comments

@Deepak8717
Copy link
Member

Describe the bug
On small screen, the active card of Expanding-card play is too wide. it's a small tweak if someone looking to get started can fix it.

Solution:
the width of .active class needs to be fixed on small screen

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://reactplay.io/plays/expanding-cards/
  2. resize the screen to smaller screen
  3. look at the active card
  4. active card looks too wide

Expected behavior
active card should be well aligned with other cards.

Screenshots

expanding-card

Desktop (please complete the following information):

  • OS: ubuntu
  • Browser brave
  • Version [e.g. 22]
@Deepak8717 Deepak8717 added bug Something isn't working good first issue New-contributor friendly labels Jun 22, 2022
@atapas
Copy link
Member

atapas commented Jun 22, 2022

@Deepak8717 will you fix this one?

@Deepak8717
Copy link
Member Author

@atapas I will fix it. but I let it taken by someone until I am busy with a new play. if no one does I will as it's just one line of code.

@lpizzinidev lpizzinidev mentioned this issue Jun 22, 2022
3 tasks
@atapas
Copy link
Member

atapas commented Jun 22, 2022

@lpizzinidev Can I assign this to you?

@NdukaClara
Copy link

@atapas Can you assign this to me?

@atapas atapas removed the good first issue New-contributor friendly label Jun 23, 2022
@atapas
Copy link
Member

atapas commented Jun 23, 2022

@atapas Can you assign this to me?

Hi @NdukaClara I see there is a PR already that @Deepak8717 is doing review.

Could you please pick up anything else from the list?

good first issue New-contributor friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants