Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - How to style a play #67

Merged
merged 6 commits into from
Sep 5, 2023
Merged

[Feature] - How to style a play #67

merged 6 commits into from
Sep 5, 2023

Conversation

supminn
Copy link
Contributor

@supminn supminn commented Jul 6, 2023

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited

✅ Deploy Preview for react-play-docs ready!

Name Link
🔨 Latest commit 7cdf541
🔍 Latest deploy log https://app.netlify.com/sites/react-play-docs/deploys/64f6e17ea172dd00078d243e
😎 Deploy Preview https://deploy-preview-67--react-play-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

atapas
atapas reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supminn Looks good.

Can you also add a note somewhere not to override the style using !important.

atapas
atapas previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

joshi-kaushal
joshi-kaushal requested changes Jul 11, 2023
View reviewed changes
docs/How-To-Guides/how-to-style-play.md Outdated Show resolved Hide resolved
docs/How-To-Guides/how-to-style-play.md Outdated Show resolved Hide resolved
docs/How-To-Guides/how-to-style-play.md Outdated Show resolved Hide resolved
docs/How-To-Guides/how-to-style-play.md Outdated Show resolved Hide resolved
docs/How-To-Guides/how-to-style-play.md Show resolved Hide resolved
docs/How-To-Guides/how-to-style-play.md Outdated Show resolved Hide resolved
@atapas atapas merged commit 18641db into main Sep 5, 2023
5 checks passed
@atapas atapas deleted the supminn/play-styling branch September 5, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas atapas approved these changes

@joshi-kaushal joshi-kaushal joshi-kaushal approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add Doc on "How to add styling to your play"
3 participants
@supminn @atapas @joshi-kaushal