-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GHA workflows to avoid warnings around output APIs #727
Labels
area/all-projects
issues that are transverse to all projects, epics
Comments
Tracking in affected projects:
|
This was referenced Oct 25, 2022
simonbasle
added a commit
to reactor/reactor-core
that referenced
this issue
Oct 25, 2022
This commit changes the way job output is defined, using the new way of a GITHUB_OUTPUT file environment variable. The old way of echoing strings is deprecated for sensitive elements, including action/job output. It also reorders the output in order to: - ensure BAD version is detected before any output and fails the job - ensure only one version/versionType is outputted when there are multiple modules (here, the `reactor-core` one) Finally it updates core and gradle actions to latest versions. This fixes warnings about deprecated output style and deprecated Node version being still in use by these actions. See reactor/reactor#727.
simonbasle
added a commit
to reactor/reactor-pool
that referenced
this issue
Oct 25, 2022
This commit changes the way job output is defined, using the new way of a GITHUB_OUTPUT file environment variable. The old way of echoing strings is deprecated for sensitive elements, including action/job output. It also reorders the output in order to: • ensure BAD version is detected before any output and fails the job • ensure only one version/versionType is outputted when there are multiple modules (here, the `reactor-pool` one) Finally it updates core and gradle actions to latest versions. This fixes warnings about deprecated output style and deprecated Node version being still in use by these actions. See reactor/reactor#727.
violetagg
added a commit
to reactor/reactor-netty
that referenced
this issue
Jan 6, 2023
violetagg
added a commit
to reactor/reactor-netty
that referenced
this issue
Jan 6, 2023
violetagg
added a commit
to reactor/reactor-addons
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
to reactor/reactor-kafka
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
to reactor/reactor-kotlin-extensions
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
to reactor/reactor-rabbitmq
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
to reactor/reactor-addons
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
to reactor/reactor-kafka
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
to reactor/reactor-kotlin-extensions
that referenced
this issue
Jan 18, 2023
violetagg
added a commit
to reactor/reactor-rabbitmq
that referenced
this issue
Jan 18, 2023
chemicL
pushed a commit
to reactor/reactor-core
that referenced
this issue
Mar 7, 2023
This commit changes the way job output is defined, using the new way of a GITHUB_OUTPUT file environment variable. The old way of echoing strings is deprecated for sensitive elements, including action/job output. It also reorders the output in order to: - ensure BAD version is detected before any output and fails the job - ensure only one version/versionType is outputted when there are multiple modules (here, the `reactor-core` one) Finally it updates core and gradle actions to latest versions. This fixes warnings about deprecated output style and deprecated Node version being still in use by these actions. See reactor/reactor#727.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
There is also a push to switch to the latest supported NodeJS runtime (
node16
), with some actions still using the older EoL version of the runtime.In the current build and workflows, several classes of warnings arise:
node16
by actionsThus there is a need to upgrade actions to the latest releases, as well as to alter the builds to use file-based output rather than echo-based output to eg. set the version type and full version parameters for further jobs.
In the gradle builds, there is also a need to reorder the output so that:
• BAD version is detected before any output and fails the job
• only one version/versionType is outputted when there are multiple modules (eg. the
reactor-core
one should take precedence overreactor-core-micrometer
)That last part is especially important in 2022.0.0 with the introduction of two submodules in
reactor-core
andreactor-pool
respectively (both have a separate version number).Example of build change
reactor-pool
at the end ofqualifyVersionGha
. otherwise this code can be copy-pasted in different projects.The text was updated successfully, but these errors were encountered: