Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#72] Apply stopOnError to Producer send Exceptions #73

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

Sage-Pierce
Copy link
Contributor

@Sage-Pierce Sage-Pierce commented Dec 13, 2018

A pass at implementing what is mentioned in #72

@codecov-io
Copy link

Codecov Report

Merging #73 into master will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
+ Coverage     80.82%   81.35%   +0.53%     
  Complexity      228      228              
============================================
  Files            18       18              
  Lines          1121     1121              
  Branches        113      113              
============================================
+ Hits            906      912       +6     
+ Misses          177      171       -6     
  Partials         38       38
Impacted Files Coverage Δ Complexity Δ
...tor/kafka/sender/internals/DefaultKafkaSender.java 90.7% <100%> (+1.32%) 32 <0> (ø) ⬇️
...kafka/receiver/internals/DefaultKafkaReceiver.java 88.96% <0%> (+0.68%) 59% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0417241...6a92d34. Read the comment docs.

@smaldini smaldini merged commit 9fd8989 into reactor:master Dec 13, 2018
@smaldini
Copy link
Contributor

Simple and efficient, thanks a lot!

@smaldini smaldini added the type/enhancement A general enhancement label Dec 13, 2018
@smaldini smaldini modified the milestones: 1.0.2.RELEASE, 1.1.1.RELEASE Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants