Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose manual stop method in KafkaReceiver #380

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Expose manual stop method in KafkaReceiver #380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86eedfb
fix typo
cjlee38 Jan 17, 2024
b774616
feat: implement to stop KafkaReceiver
cjlee38 Jan 17, 2024
15a8553
chore: sanitize unused
cjlee38 Jan 17, 2024
a1539bf
fix test & imports
cjlee38 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: sanitize unused
  • Loading branch information
@cjlee38
cjlee38 committed Jan 17, 2024
commit 15a85533992cb871c6599521f8e1a34b68bcdde6
3 changes: 0 additions & 3 deletions src/main/java/reactor/kafka/receiver/internals/ConsumerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@
* To be exposed as a public class in the next major version (a subject to the API review).
*/
class ConsumerHandler<K, V> {

private static final Logger log = LoggerFactory.getLogger(ConsumerHandler.class);

/** Note: Methods added to this set should also be included in javadoc for {@link KafkaReceiver#doOnConsumer(Function)} */
private static final Set<String> DELEGATE_METHODS = new HashSet<>(Arrays.asList(
"assignment",
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/reactor/kafka/receiver/KafkaReceiverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,7 +1538,7 @@ private Disposable subscribe(Flux<? extends ConsumerRecord<Integer, String>> kaf
return disposable;
}

private void waitFoPartitionAssignment() throws InterruptedException { // todo : typo
private void waitFoPartitionAssignment() throws InterruptedException {
assertTrue("Partitions not assigned", assignSemaphore.tryAcquire(sessionTimeoutMillis + 1000, TimeUnit.MILLISECONDS));
}

Expand Down