fix(android): onSelect was crashing android #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GETAWAY-Dev
approved these changes
Apr 13, 2024
react-native-maps-bot
pushed a commit
that referenced
this pull request
Apr 13, 2024
## [1.13.1](v1.13.0...v1.13.1) (2024-04-13) ### Bug Fixes * **android:** onSelect was crashing android ([#5032](#5032)) ([b3ce3fc](b3ce3fc))
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Super-CodeKing
added a commit
to Super-CodeKing/react_native_map
that referenced
this pull request
Apr 26, 2024
## [1.13.1](react-native-maps/react-native-maps@v1.13.0...v1.13.1) (2024-04-13) ### Bug Fixes * **android:** onSelect was crashing android ([#5032](react-native-maps/react-native-maps#5032)) ([b3ce3fc](react-native-maps/react-native-maps@b3ce3fc))
fairskyDev0201
pushed a commit
to fairskyDev0201/react-native-maps
that referenced
this pull request
Apr 29, 2024
## [1.13.1](react-native-maps/react-native-maps@v1.13.0...v1.13.1) (2024-04-13) ### Bug Fixes * **android:** onSelect was crashing android ([#5032](react-native-maps/react-native-maps#5032)) ([b3ce3fc](react-native-maps/react-native-maps@b3ce3fc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
Wrong event type was being used for onSelect on android for MapMarker, it seems like since it's a common event name it should follow the same type implemented by other react-native components, in this case bubbling event.
5030
How did you test this PR?
On an android device