feat(AIRGoogleMapsMarker): add onSelect/onDeselect support fo google maps

[jan-kozinski]

Does any other open PR do the same thing?

no

What issue is this PR fixing?

#4970

#114

How did you test this PR?

andoid emulator & ios simulator

[EJohnF]

Wow! i was looking for this functionality, and you just pushed it 🎉

[mateki0]

Looks and works fine on iOS simulator and Android device. I'm just thinking if second press on the same marker shouldn't be considered as deselect on iOS. It works like that on Android though.

[jan-kozinski]

Thanks @mateki0 good catch! I've tweaked the google maps implementation to match the mapkit one's. The mapkit implementation is the original one and is implemented by mapkit itself. So no it should be impossible to deselect a marker by clicking on it multiple times. Also I've added the onMarkerSelect and onMarkerDeselect functionality since its related

[salah-ghanim]

@jan-kozinski the code looks good, but I have a small feedback

I wouldn't change the AIRGoogleMapMarker.m eventFromMarker AIRGMSMarker.m for some reason that class was left empty all the history of the repo, I would simply keep the same tradition.

instead just modify the function in AIRGoogleMapMarker to accept action as a parameter, for example:

eventFromMarker: marker action:(_Nullable NSString *) action {
}

finally, In general I would avoid adding anything to the .h files, because that implies new public interfaces / functionality ... I don't see the need for such APIs most of the time, rather the body of a class (.m file) can manage the state internally and propagate the events correctly as you can see.

[jan-kozinski]

Hi @salah-ghanim thanks for the feedback. I've added the makeEventData to the AIRGMSMarker, because selectedMarker in AIRGoogleMap must ba an instance of GSMMarker (it can't be a AIRGoogleMapMarker because the super setSelectedMarker expects a AIRGMSMarker.
Still, I wanted both classes to use the same method for event generating as to avoid incosistent marker events in future.
EDIT:
found out it is actually possible to get the instance of AIRGoogleMapMarker through fakeMarker property of AIRGMSMarker, so I'm moving the implementation to AIRGoogleMapMarker as suggested

[jan-kozinski]

Also thanks for the advice with .h files, I've removed as many public interfaces as possible. Removing them further causes the code to not compile, so you can take a second look when you got time @salah-ghanim .

[react-native-maps-bot]

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀