-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Build Android APK step #33
Labels
Comments
compojoom
added a commit
to compojoom/react-native-circleci-orb
that referenced
this issue
Jan 14, 2020
Add more parameters to the android_build command. This allows us to be more explicit with our build variants and it terms will save minutes on circleCI by only specifying the build variantes that we really needs fixes react-native-community#33
5 tasks
@compojoom Our project also has variants made of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the Build Android APK step looks like this:
In our project we have 3 flavors(develop, staging, production) and 2 build types (debug and release).
if I assemble the app with
gradlew will build all 3 flavors in release type. and it will also build all 3 flavors for androidTest in release type. This takes around 10mins on my machine and a little longer on circleci.
To speed this up we are generally only building specific build variants DevelopDebug, DevelopRelease etc.
To build a detox build we would do:
this way we only generate developRlease androidTest/developRelease - this is 3 times faster as we generate 3 times less apks that we don't need.
Because of that I would like to propose different job parameters:
assemble_build_type
,assemble_detox_build_type
andtest_build_type
.This way one could call rn/android_build like this:
It is a breaking change, but it would also allow for greater flexibility of the build step.
The text was updated successfully, but these errors were encountered: