Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preview zIndex should pass into operations #288

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat: preview zIndex should pass into operations #288

merged 1 commit into from
Nov 21, 2023

Conversation

kiner-tang
Copy link
Contributor

@kiner-tang kiner-tang commented Nov 21, 2023 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 4:14am

crazyair
crazyair reviewed Nov 21, 2023
View reviewed changes
src/Operations.tsx
style={style}
style={{
...style,
zIndex,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

禁止用户覆盖 zIndex 吗？其他都是这样弄的？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 zIndex 本身就是从 preview 传过来用户自定义的 zIndex

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSSMotion 的 style 里面有 zIndex 吗

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们给的应该是没有的，这个也不能参与动画计算

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恩，那顺序不重要了

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd92f7d) 97.91% compared to head (6760acc) 97.91%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          13       13           
  Lines         383      383           
  Branches      107      107           
=======================================
  Hits          375      375           
  Misses          7        7           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit d2f3f62 into react-component:master Nov 21, 2023
9 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@crazyair crazyair crazyair left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiner-tang @zombieJ @crazyair