Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing project that uses unknown/missing catalogue uses random other catalogue #455

Closed
hardfalcon opened this issue Apr 21, 2022 · 6 comments

Comments

@hardfalcon
Copy link

It appears that if you import a project which uses a catalogue that the importing RDMO instance doesn't know, another random catalogue is used instead without even showing a warning. This bug was found by @jmfrenzel.

@jochenklar
Copy link
Member

It should be the first catalog that is used, I guess we should add a warning in the import screen.

@jmfrenzel
Copy link
Member

jmfrenzel commented Apr 21, 2022

It should be the first catalog that is used, I guess we should add a warning in the import screen.

can confirm that it is the first catalog (first according to the catalog order in the instance).

More importantly that first catalog is selected even when this catalog has the not available flag set.

@jochenklar
Copy link
Member

More importantly that first catalog is selected even when this catalog has the not available flag set.

Yeah, this is not optimal.

@hardfalcon
Copy link
Author

hardfalcon commented Apr 21, 2022

Wouldn't it be better to outright reject the import if it uses an unknown catalog? My fear is that people assume some sort of "sane" behavior if the catalog used doesn't actually fit the questions answered, when IMO there is no "sane" behavior to handle this other than reject the import in the first place.

@jochenklar
Copy link
Member

I beg to differ, catalogs can be chnged in RDMO and sometimes you want to import a project into an instance which does not have this catalog. I think we just need to make the behavior more visible.

@jochenklar jochenklar added this to the 1.10.0 milestone Dec 7, 2022
@jochenklar jochenklar self-assigned this Jan 23, 2023
@MyPyDavid MyPyDavid modified the milestones: 1.10.0, 1.11.0 Apr 21, 2023
@jochenklar jochenklar modified the milestones: 1.11.0, 2.0.0 Apr 27, 2023
@MyPyDavid MyPyDavid modified the milestones: 2.0.0, RDMO 2.3.0 Mar 11, 2024
@jochenklar jochenklar modified the milestones: RDMO 2.3.0, RDMO 2.2.0 Jun 6, 2024
@jochenklar
Copy link
Member

Will be part of RDMO 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants