Fix embedded notes not generating proper reference links (foambubble#…

…1286)

packages/foam-vscode/src/core/services/markdown-provider.test.ts

@@ -316,4 +316,40 @@ describe('Generation of markdown references', () => {
  '../dir3/page-c.md',
  ]);
  });
+
+ it('should generate links for embedded notes that are formatted properly', () => {
+ const workspace = createTestWorkspace();
+ const noteA = createNoteFromMarkdown(
+ 'Link to ![[page-b]] and [[page-c]]',
+ '/dir1/page-a.md'
+ );
+ workspace
+ .set(noteA)
+ .set(createNoteFromMarkdown('Content of note B', '/dir2/page-b.md'))
+ .set(createNoteFromMarkdown('Content of note C', '/dir3/page-c.md'));
+
+ const references = createMarkdownReferences(workspace, noteA.uri, true);
+ expect(references.map(r => [r.url, r.label])).toEqual([
+ ['../dir2/page-b.md', 'page-b'],
+ ['../dir3/page-c.md', 'page-c'],
+ ]);
+ });
+
+ it('should not generate links for placeholders', () => {
+ const workspace = createTestWorkspace();
+ const noteA = createNoteFromMarkdown(
+ 'Link to ![[page-b]] and [[page-c]] and [[does-not-exist]] and ![[does-not-exist-either]]',
+ '/dir1/page-a.md'
+ );
+ workspace
+ .set(noteA)
+ .set(createNoteFromMarkdown('Content of note B', '/dir2/page-b.md'))
+ .set(createNoteFromMarkdown('Content of note C', '/dir3/page-c.md'));
+
+ const references = createMarkdownReferences(workspace, noteA.uri, true);
+ expect(references.map(r => r.url)).toEqual([
+ '../dir2/page-b.md',
+ '../dir3/page-c.md',
+ ]);
+ });
 });

packages/foam-vscode/src/core/services/markdown-provider.ts

@@ -139,10 +139,12 @@ export function createMarkdownReferences(
 
  // [wikilink-text]: path/to/file.md "Page title"
  return {
- label:
- link.rawText.indexOf('[[') > -1
- ? link.rawText.substring(2, link.rawText.length - 2)
- : link.rawText,
+ // embedded looks like ![[note-a]]
+ // regular note looks like [[note-a]]
+ label: link.rawText.substring(
+ link.isEmbed ? 3 : 2,
+ link.rawText.length - 2
+ ),
  url: relativeUri.path,
  title: target.title,
  };