Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile generation on linux systems fix #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbeltagy
Copy link

@mbeltagy mbeltagy commented May 1, 2018

... also jl_init takes not arguments on Julia 0.63... so I had to fix.
This fixes #2

@rcqls
Copy link
Owner

rcqls commented May 1, 2018

Not sure that the linux installation on ubuntu is compatible with your change....
Also, jl_init has to consider earlier version of Julia....

@mbeltagy
Copy link
Author

mbeltagy commented May 1, 2018

I don't think you need to worry about previous versions of Julia. See
https://discourse.julialang.org/t/julia-0-5-is-now-officially-unmaintained/8169

@rcqls
Copy link
Owner

rcqls commented May 1, 2018

Good point! Thanks! So maybe standard install has changed too on linux...

@mbeltagy
Copy link
Author

mbeltagy commented May 1, 2018

I don't think it a good idea to ask the user for JULIA_DIR or try to guess where it might be on any given system. This could be done automatically and julia is happy to provide you will the compiler flags etc.
Checkout the subsection "Use in Makefiles" at
https://docs.julialang.org/en/stable/manual/embedding/#High-Level-Embedding-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile complie errors
2 participants