Add configuration parameter to be able to set the unique id part in HA #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbroker
reviewed
Mar 11, 2024
README.md
Outdated
| | ----------- | ------------| -------- | | ||
| | `Unique Id` | Identifier to be used in Home Assistant sensors for this device. It should be unique for each Ecodan HVAC in the network. | False (It uses MAC address by default) | | ||
|
|
||
| Changing the defaul value can be used to replace the ESP device without having to reconfigure the entities in Home Assistant or the software reading the MQTT messages and writing the values in influxdb. |
There was a problem hiding this comment.
It's a very tiny thing but I guess this should say default?
ecodan-ha-local/ehal_http.cpp
Outdated
| @@ -173,6 +174,11 @@ namespace ehal::http | |||
| else | |||
| page.replace(F("{{cool_enabled}}"), ""); | |||
|
|
|||
| if (config.UniqueId) | |||
There was a problem hiding this comment.
I guess because this is a string not a boolean it might be clearer if we wrote it as:
if (config.UniqueId.length() > 0)
|
Thanks Richard I made both changes as suggested. |
|
Thank you! |
|
Thanks Richard for your good work and generosity. The idea for this change originated when I had a problem with my ESP and tried to replace it with a different one. I was a whole day without data from my HVAC and I felt a little bit lost. That's how much I benefit from this project 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a change to be able to set the unique identifier part in sensors name in Home Assistant.
This can be useful in case you want to replace the ESP without having to reconfigure automations, etc in Home Assistant.
I tested the changes replacing my ESP with a new one and managing the device in Home Assistant as it was the old one.
Consider merging the code in case you think it could benefit anyone.
Thanks
Carlos