Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to switch Off/On Ecodan system from HA #13

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

limkinZero
Copy link
Contributor

@limkinZero limkinZero commented Nov 12, 2023

This PR add new control in home assistant to set power mode to allow turn on/off the ecodan system.

image

Also, the doc has been updated to explain what controls and sensors taking out.

@limkinZero limkinZero changed the title Add support to swith Off/On Ecodan system from HA Add support to switch Off/On Ecodan system from HA Nov 12, 2023
Copy link
Owner

@rbroker rbroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good apart from the locking issue which I guess is a bug I introduced somewhere - sorry!

ecodan-ha-local/ehal_hp.cpp Outdated Show resolved Hide resolved
ecodan-ha-local/ehal_proto.h Outdated Show resolved Hide resolved
@limkinZero
Copy link
Contributor Author

Hi, @rbroker, tell me if you see it well to merge. In principle with my tests all works ok

@rbroker rbroker merged commit 00cbd1c into rbroker:main Nov 14, 2023
@rbroker
Copy link
Owner

rbroker commented Nov 14, 2023

Thanks! I've merged that now, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants