Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control cool modes from HA #11

Merged
merged 5 commits into from
Nov 11, 2023
Merged

Allow control cool modes from HA #11

merged 5 commits into from
Nov 11, 2023

Conversation

limkinZero
Copy link
Contributor

This PR allow configure cool modes from HA.

Also, it has been added a new configuration zone to set heat pump parameters. The idea is that through parameters, enable or not support for functionalities that may not have all the most ecodan HVAC like cool mode, dual zones, DHW, ...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If config.CoolEnabled is set, do you want to add it to the list of supported modes in publish_ha_climate_auto_discover() as well?

If so, you'll probably want to tweak ha_mode_as_string() in ehal_hp.h as well, so that it can report back whether it's trying to heat or cool (as that will be used to indicate whether the heating is on/off or heating in publish_climate_status().

Copy link
Owner

@rbroker rbroker Nov 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, correction here, the operation mode (from ha_action_as_string()) is probably more useful, and that only currently supports indicating either "heating" or "idle" for the climate entity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. @rbroker. Thanks for your comments. I´ve reviewed and changed what you mentioned. Also, while checking the BartGijsbers repo, I saw that there is a OperationMode status (2) that indicates that it is cooling. I've been testing it this morning and in principle it works well.

@rbroker rbroker merged commit fa59f02 into rbroker:main Nov 11, 2023
@rbroker
Copy link
Owner

rbroker commented Nov 11, 2023

Thanks again! The updated changes look good to me so I've merged it, hopefully it all looks ok with the climate control in homeassistant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants