-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add later extension #12901
Add later extension #12901
Conversation
Congratulations on your new Raycast extension! 🚀 We have a lower capacity at the moment, and extension reviews might take longer than usually to get the initial review. Once the PR is approved and merged, the extension will be available on our Store. Sorry for the inconvenience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this, but when using Later - Read It Later
, I ended up with this error (was using Arc at the time)
09:59:59.189 Error: Command failed: osascript -e
0:9: execution error: Variablen undefined er ikke defineret. (-2753)
at ChildProcess.exithandler (node:child_process:422:12)
at ChildProcess.emit (node:events:514:28)
at ChildProcess.emit (node:domain:488:12)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
code: 1,
killed: false,
signal: null,
cmd: 'osascript -e ',
stdout: '',
stderr: '0:9: execution error: Variablen undefined er ikke defineret. (-2753)\n'
}
Do you have any idea what might be causing this?
Thank you for your finding. There are some details I want you to provide:
|
Yes, it also happens with Chrome (and Arc of course), both in the newest versions. I'm having the browser in front before running the command. Nothing changed besides the error in the console |
I was able to do some more testing:
|
I think if I got the user's default browser, saving links and opening links would be intuitive and out of the box. Appending a preference view for choosing a default browser is another good solution, I will make a tradeoff about that. Thank you for advising. |
Thanks for looking into this, a lot is using Velja and other managers so I think it will happen pretty often |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add the preferences the right place, you shouldn't use a command for that 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Looks good to me, approved 🔥
Published to the Raycast Store: |
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@Ross249). |
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder