Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add later extension #12901

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Add later extension #12901

merged 9 commits into from
Jun 21, 2024

Conversation

Ross249
Copy link
Contributor

@Ross249 Ross249 commented Jun 12, 2024

Description

Screencast

Checklist

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jun 12, 2024
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

We have a lower capacity at the moment, and extension reviews might take longer than usually to get the initial review. Once the PR is approved and merged, the extension will be available on our Store.

Sorry for the inconvenience

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, but when using Later - Read It Later, I ended up with this error (was using Arc at the time)

09:59:59.189 Error: Command failed: osascript -e  
0:9: execution error: Variablen undefined er ikke defineret. (-2753)

    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:514:28)
    at ChildProcess.emit (node:domain:488:12)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 1,
  killed: false,
  signal: null,
  cmd: 'osascript -e  ',
  stdout: '',
  stderr: '0:9: execution error: Variablen undefined er ikke defineret. (-2753)\n'
}

Do you have any idea what might be causing this?

@pernielsentikaer pernielsentikaer self-assigned this Jun 18, 2024
@Ross249
Copy link
Contributor Author

Ross249 commented Jun 18, 2024

I tried this, but when using Later - Read It Later, I ended up with this error (was using Arc at the time)

09:59:59.189 Error: Command failed: osascript -e  
0:9: execution error: Variablen undefined er ikke defineret. (-2753)

    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:514:28)
    at ChildProcess.emit (node:domain:488:12)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 1,
  killed: false,
  signal: null,
  cmd: 'osascript -e  ',
  stdout: '',
  stderr: '0:9: execution error: Variablen undefined er ikke defineret. (-2753)\n'
}

Do you have any idea what might be causing this?

Thank you for your finding. There are some details I want you to provide:

  1. Arc version code
  2. Did your Arc open or not while using Later - Read It Later Command
  3. Did this problem appear in other browsers likeMicrosoft Edge, Chrome?

@pernielsentikaer
Copy link
Collaborator

Yes, it also happens with Chrome (and Arc of course), both in the newest versions. I'm having the browser in front before running the command.

Nothing changed besides the error in the console

@pernielsentikaer
Copy link
Collaborator

I was able to do some more testing:

  • The error is occurring because I use Velja as middleware for the browser. Maybe we should let the user set their preferred browser in preferences instead?

  • use useForm in the form for adding new entries since it comes with validation and haldling of states 🙂

  • The delete action should maybe have style={Action.Style.Destructive} and a confirmAlert?

@Ross249
Copy link
Contributor Author

Ross249 commented Jun 19, 2024

I was able to do some more testing:

  • The error is occurring because I use Velja as middleware for the browser. Maybe we should let the user set their preferred browser in preferences instead?
  • use useForm in the form for adding new entries since it comes with validation and haldling of states 🙂
  • The delete action should maybe have style={Action.Style.Destructive} and a confirmAlert?

I think if I got the user's default browser, saving links and opening links would be intuitive and out of the box. Appending a preference view for choosing a default browser is another good solution, I will make a tradeoff about that. Thank you for advising.

@pernielsentikaer
Copy link
Collaborator

Thanks for looking into this, a lot is using Velja and other managers so I think it will happen pretty often

@pernielsentikaer pernielsentikaer mentioned this pull request Jun 20, 2024
5 tasks
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the preferences the right place, you shouldn't use a command for that 🙂

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit ed79007 into raycast:main Jun 21, 2024
1 check passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/jimluo/later

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@Ross249).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants