Ext/GitHub smart notification

[shoppingjaws]

Description

Github Notification Viewer

• automatically read unnecessary notification
• automatically read notification based on configured rule

Screencast

Checklist

• I read the extension guidelines
• I read the documentation about publishing
• I ran npm run build and tested this distribution build in Raycast
• I checked that files in the assets folder are used by the extension itself
• I checked that assets used by the README are placed outside of the metadata folder

[shoppingjaws]

changes

Thank you for reviewing. re-submit my PR.

• move form view from root command into configuration view.
• set default command path.
• set notification view item icons sourced from repository icon

[shoppingjaws]

@pernielsentikaer Updated 👍

[pernielsentikaer]

Hi 👋

I have now tested your extension, and I have some feedback ready for you:

• If you're opening the menubar command as the first thing, then there is no data since it doesn't fetch items, maybe it should do that?

• It's still possible to add a new configuration without a description

• add a confirmAlert when you delete the notification and add a missing icon Icon.Trash maybe?

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

[pernielsentikaer]

Suggested change

	{
	"name": "ghCommandPath",
	"title": "gh command binary PATH",
	"description": "Installed Path of gh command",
	"type": "textfield",
	"required": false,
	"default": "/opt/homebrew/bin/gh"
	},
	{
	"name": "autoReadMergedPr",
	"title": "automatically read merged PR",
	"description": "if true, merged PR will be read",
	"default": true,
	"type": "checkbox",
	"label": "checkbox",
	"required": true
	}
	{
	"name": "ghCommandPath",
	"title": "gh Command Binary PATH",
	"description": "Installed Path of gh command",
	"type": "textfield",
	"required": false,
	"default": "/opt/homebrew/bin/gh"
	},
	{
	"name": "autoReadMergedPr",
	"title": "Options",
	"description": "if true, merged PR will be read",
	"default": true,
	"type": "checkbox",
	"label": "Automatically mark merged PRs as read",
	"required": true
	}

[pernielsentikaer]

Suggested change

	title="Mark As Read"
	title="Mark as Read"

[raycastbot]

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

[shoppingjaws]

@pernielsentikaer Hi, I updated.

• add alert and trash icon to the configuration view on delete.

If you're opening the menubar command as the first thing, then there is no data since it doesn't fetch items, maybe it should do that?

• You mean adding the loading logic, right?

[pernielsentikaer]

Yes, that would make sense since the command and menubar uses the same cache

[shoppingjaws]

@pernielsentikaer Ive already added loading logic to the menubar.tsx.
when isLoading is set true when the state is undefined. The menubar becomes invisible while the fetching task is in progress. Isn’t this enough?

[mil3na]

Hi! Is this ready for the next review?

[shoppingjaws]

@pernielsentikaer yes, please 👍

[mil3na]

Hi! Per is on vacation, so I will be reviewing your extension.
I wonder if this wouldn't be a better addition to the Github extension instead. https://www.raycast.com/raycast/github/commands
There, we already have a notification command, you could add a filter as a preference.
What do you think?

[shoppingjaws]

@pernielsentikaer @mil3na That's good idea. Is it too late to suggest that?
I'd love to port this feature to a Github extension, but why not wait until you've released it?

[mil3na]

The Github extension is opensource and open for contributions. Feel free to add this functionality there! I will close this PR for now :)

[shoppingjaws]

If so, I wish you had suggested it a little earlier.

[mil3na]

I suggested as soon as I saw and reviewed your PR :)
if you want to discuss it, please reach out on our Slack community https://raycast.com/community