ignore signature results for other buffers #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language servers can be slow to respond to the `textDocument/signatureHelp` request. During that time, the user could have moved to another buffer. The signature would be shown for the current buffer even though it was meant for some other buffer. Let's only show the signature if it is for the current buffer. This bugfix is cherry-picked from the Neovim core `signature_help` LSP handler [0]. [0]: neovim/neovim#21121
ray-x
approved these changes
Nov 20, 2022
|
Thanks for merging the PR! Yeah, the delay may also be from there, but in my case, it is definitely tsserver choking on the size of the project. I have the same delays for diagnostics, hover information, autocomplete, etc 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language servers can be slow to respond to the
textDocument/signatureHelprequest. During that time, the user could have moved to another buffer. The signature would be shown for the current buffer even though it was meant for some other buffer.In this reproduction, I modify some code to make
tsserverbusy, quickly ask forsignatureHelpand then quickly open Telescope:Peek.2022-11-19.12-52.signature.not.ignored.causes.an.erorr.mp4
Let's only show the signature if it is for the current buffer.
The same Telescope bug reproduction with the fix from this PR (it no longer causes an error because the signature is ignored):
Peek.2022-11-19.12-53.mp4
This bugfix is cherry-picked from the Neovim core
signature_helpLSP handler.