Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Work around msgpack issue on PowerPC64LE #9140

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

mehrdadn
Copy link
Contributor

Why are these changes needed?

On some compilers on RHEL 7.6 it appears msgpack's check for __unix doesn't work, so we also check for __unix__.

Related issue number

Closes #9138.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27559/
Test PASSed.

@richardliaw richardliaw changed the title Work around msgpack issue on PowerPC64LE [windows] Work around msgpack issue on PowerPC64LE Jun 26, 2020
@richardliaw richardliaw merged commit 11bda72 into ray-project:master Jun 26, 2020
@mehrdadn mehrdadn deleted the ppc64le branch June 26, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ray] Build fails for '//:ray_common' on ppc64le
4 participants