Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[general] Remove 'whitelist' #8995

Merged
merged 1 commit into from
Jun 17, 2020
Merged

[general] Remove 'whitelist' #8995

merged 1 commit into from
Jun 17, 2020

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Jun 17, 2020

Why are these changes needed?

Related issue number

Similar to #8994--just cleaning up comments :)

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@ijrsvt ijrsvt requested a review from sven1977 June 17, 2020 16:11
sven1977
sven1977 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@sven1977 sven1977 merged commit 2e972c2 into ray-project:master Jun 17, 2020
@ijrsvt ijrsvt deleted the whitelist_removal_cleanup branch June 17, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijrsvt @sven1977