Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Done to MultiAgentExternalEnv. #8478

Merged
merged 1 commit into from
May 17, 2020
Merged

Added Done to MultiAgentExternalEnv. #8478

merged 1 commit into from
May 17, 2020

Conversation

devanderhoff
Copy link
Contributor

Why are these changes needed?

Some bugfixes and the addition of Done to MultiAgentExternalEnv.
This is a redo of a previous PR.

Related issue number

Redo of #8187

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@ericl ericl self-assigned this May 17, 2020
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26003/
Test PASSed.

@ericl ericl merged commit be1f158 into ray-project:master May 17, 2020
@ericl
Copy link
Contributor

ericl commented May 17, 2020

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devanderhoff @AmplabJenkins @ericl