Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore unset -f cd #8467

Merged
merged 1 commit into from
May 16, 2020
Merged

Restore unset -f cd #8467

merged 1 commit into from
May 16, 2020

Conversation

mehrdadn
Copy link
Contributor

@mehrdadn mehrdadn commented May 16, 2020 •
edited
Loading

Why are these changes needed?

The macOS builds seem to break with the Ruby cd for some reason.

Related issue number

#8463

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

simon-mo
simon-mo approved these changes May 16, 2020
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure wheel uploads still work after merge.

@simon-mo
Copy link
Contributor

Merging because Mac is building and testing now. This is a hotfix

@simon-mo simon-mo merged commit c8cd716 into ray-project:master May 16, 2020
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25971/
Test PASSed.

@mehrdadn mehrdadn deleted the fix-ci branch May 17, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehrdadn @AmplabJenkins @simon-mo @web-flow