Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST]use cc_test to run core_worker_test, enforce/reuse RedisServiceManagerForTest #8443

Merged
merged 7 commits into from
May 17, 2020

Conversation

WangTaoTheTonic
Copy link
Contributor

@WangTaoTheTonic WangTaoTheTonic commented May 14, 2020

Why are these changes needed?

Now core_worker_test is ran by scripts run_core_worker_tests.sh, which demand specified location and departed from all other tests.

RedisServiceManagerForTest is used for starting redis server for test cases who need that. Now it could only start one server with random port. We enforce it with multiple redis servers and optional port supporting, thus it can be used by more diverse cases.

We use RedisServiceManagerForTest enforced to start/shutdown redis servers for core_worker_tests and make former reusable.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25883/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25888/
Test FAILed.

@ffbin ffbin requested a review from raulchen May 15, 2020 02:17
@ffbin ffbin self-requested a review May 15, 2020 02:18
@WangTaoTheTonic
Copy link
Contributor Author

WangTaoTheTonic commented May 15, 2020

There's a failure test case(about tune restore) which should be unrelated with this pr as it had failed in others.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25923/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25924/
Test FAILed.

src/ray/common/test_util.cc Show resolved Hide resolved
src/ray/common/test_util.cc Outdated Show resolved Hide resolved
src/ray/core_worker/test/core_worker_test.cc Show resolved Hide resolved
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25965/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25972/
Test PASSed.

Copy link
Contributor

@zhijunfu zhijunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zhijunfu zhijunfu merged commit acffdb2 into ray-project:master May 17, 2020
@WangTaoTheTonic WangTaoTheTonic deleted the inline_core_worker_test branch May 18, 2020 01:24
@WangTaoTheTonic WangTaoTheTonic restored the inline_core_worker_test branch May 19, 2020 13:47
@WangTaoTheTonic WangTaoTheTonic deleted the inline_core_worker_test branch May 20, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants