[TEST]use cc_test to run core_worker_test, enforce/reuse RedisServiceManagerForTest #8443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Now core_worker_test is ran by scripts
run_core_worker_tests.sh
, which demand specified location and departed from all other tests.RedisServiceManagerForTest is used for starting redis server for test cases who need that. Now it could only start one server with random port. We enforce it with multiple redis servers and optional port supporting, thus it can be used by more diverse cases.
We use RedisServiceManagerForTest enforced to start/shutdown redis servers for core_worker_tests and make former reusable.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.