Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Fix SKLearn example against newest version #8428

Merged
merged 1 commit into from
May 13, 2020
Merged

[Serve] Fix SKLearn example against newest version #8428

merged 1 commit into from
May 13, 2020

Conversation

simon-mo
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@simon-mo simon-mo requested a review from edoakes May 13, 2020 20:49
edoakes
edoakes approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@simon-mo
Copy link
Contributor Author

Serve tests passed on both linux and traivs, lint is green as well. Merging...

@simon-mo simon-mo merged commit 122353c into ray-project:master May 13, 2020
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/25852/
Test FAILed.

mfitton pushed a commit to mfitton/ray that referenced this pull request May 14, 2020
@simon-mo
[Serve] Fix SKLearn example against newest version (ray-project#8428)
91d31ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-mo @AmplabJenkins @edoakes