Fix documentation building with psutil issue #7077
Conversation
|
Can one of the admins verify this patch? |
doc/source/conf.py
Outdated
| @@ -62,6 +62,7 @@ | |||
| # add these directories to sys.path here. If the directory is relative to the | |||
| # documentation root, use os.path.abspath to make it absolute, like shown here. | |||
| sys.path.insert(0, os.path.abspath("../../python/")) | |||
| sys.path.insert(0, os.path.abspath("../../python/ray/thirdparty_files")) | |||
There was a problem hiding this comment.
Can you add a comment explaining what this is for? In particular, that it is to get psutil?
Another alternative is to just put psutil into requirements-doc.txt
|
There is a deeper problem which is that the CI didn't catch the error. We should set things up so that it fails in the CI if it is going to fail in Readthedocs. Maybe the issue here is that we are installing psutil in Travis in install-dependencies.sh or something like that, which is why travis didn't catch it? If that's the case, then we should uninstall it for the linting. |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
simon-mo
force-pushed
the
doc/build-with-psutil
branch
from
900e653
to
50246f3
Compare
|
Test PASSed. |
|
@robertnishihara this is ready for review now. I removed psutil and setproctitle from CI environments. |
|
Test PASSed. |
python/ray/test_utils.py
Outdated
| @@ -6,10 +6,9 @@ | |||
| import tempfile | |||
| import time | |||
|
|
|||
| import ray # noqa F401 | |||
| import psutil | |||
There was a problem hiding this comment.
| import psutil | |
| import psutil # We must import psutil after ray because we bundle psutil with ray. |
python/ray/tests/test_metrics.py
Outdated
| import pytest | ||
| import requests | ||
| import time | ||
|
|
||
| import ray | ||
| import psutil |
There was a problem hiding this comment.
| import psutil | |
| import psutil # We must import psutil after ray because we bundle psutil with ray. |
Also move this to after all of the Ray imports (separated by a new line).
ci/travis/check_import_order.py
Outdated
| check_to_lines[check] = i | ||
| # print("{}:{} {}".format(str(file), i, line)) |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.