Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public facing references to --redis-address. #6631

Merged
merged 3 commits into from
Dec 31, 2019

Conversation

robertnishihara
Copy link
Collaborator

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

"from the node you wish to add. You can connect a driver to the "
"cluster from Python by running\n\n"
" import ray\n"
" ray.init(redis_address=\"{}{}{}\")\n\n"
" ray.init(address='auto'{})\n\n"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really when we do address='auto' it should be able to automatically detect the Redis password.

for worker_index in range(args.num_workers)]
workers = [
Worker.remote(worker_index) for worker_index in range(args.num_workers)
]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue here is not that I have the wrong version of yapf (I'm using 0.23.0) but rather that these files haven't been touched in a while?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20164/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20204/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20206/
Test PASSed.

@robertnishihara robertnishihara merged commit d2c6457 into ray-project:master Dec 31, 2019
@robertnishihara robertnishihara deleted the redisaddress branch December 31, 2019 21:21
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20238/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants