Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch arrow for Windows #6363

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Patch arrow for Windows #6363

merged 2 commits into from
Dec 6, 2019

Conversation

mehrdadn
Copy link
Contributor

@mehrdadn mehrdadn commented Dec 4, 2019

Why are these changes needed?

Fixes some compatibility issues with Arrow on Windows.

Related issue number

#631

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19203/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19205/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19222/
Test FAILed.

@mehrdadn mehrdadn marked this pull request as ready for review December 5, 2019 22:50
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! After we get it fully working and tested, let's upstream the changes to arrow too :)

@pcmoritz pcmoritz merged commit 1710337 into ray-project:master Dec 6, 2019
@mehrdadn
Copy link
Contributor Author

mehrdadn commented Dec 6, 2019

Yeah hopefully. I'm not entirely sure what the correct way to handle static and dynamic linking is unfortunately so for some of these we'd probably want to upstream after we've figured that out.

@mehrdadn mehrdadn deleted the win-arrow branch December 9, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants