Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Boost via our own rule instead of managing our own fork #6238

Merged
merged 3 commits into from
Nov 23, 2019
Merged

Update Boost via our own rule instead of managing our own fork #6238

merged 3 commits into from
Nov 23, 2019

Conversation

mehrdadn
Copy link
Contributor

@mehrdadn mehrdadn commented Nov 22, 2019 •
edited
Loading

Why are these changes needed?

Updates Boost and rules_boost to resolve Windows compatibility issues.
Also uses https://github.com/nelhage/rules_boost directly directly, removing the need maintaining our own fork.

Related issue number

#631

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mehrdadn mehrdadn changed the title Declare our own Boost rule instead of managing our own fork Update Boost via our own rule instead of managing our own fork Nov 22, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18721/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18722/
Test PASSed.

@mehrdadn mehrdadn force-pushed the rules_boost branch 2 times, most recently from 6983a2c to 94d0949 Compare November 22, 2019 12:43
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18729/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18746/
Test PASSed.

@web-flow
Use the rules_boost repository directly and declare our own Boost rul…
d0ed4e9 
…e instead of managing our own fork.

Remove bazel_skylib because rules_boost defines it internally and needs a different version.
@web-flow
Update to a more recent rules_boost version that resolves a Windows b…
b3b74f9 
…uild issue with assembly files.
@web-flow
Backport Clang-Cl patch from Boost 1.69 to Boost 1.68
d8f4357
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18750/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18753/
Test PASSed.

@pcmoritz pcmoritz merged commit 94d37ee into ray-project:master Nov 23, 2019
@mehrdadn mehrdadn deleted the rules_boost branch November 23, 2019 00:15
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18764/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mehrdadn @AmplabJenkins @pcmoritz @web-flow