Deprecate old global state API. #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
raulchen
reviewed
Aug 21, 2019
python/ray/state.py
Outdated
| "removed in a subsequent release. Use ray.objects() instead.") | ||
| raise DeprecationWarning( | ||
| "ray.global_state.object_table() is deprecated. Use ray.objects() " | ||
| "instead.") | ||
| return ray.objects(object_id=object_id) |
There was a problem hiding this comment.
this should be removed now
There was a problem hiding this comment.
Fixed, thanks!
simon-mo
approved these changes
Aug 21, 2019
26ffe67
to
108869a
Compare
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In #4857, we reorganized the global state API. So far, we have been printing warnings saying that the old API will be deprecated, but still allowing the commands to succeed. This PR raises an exception telling the user what the correct command to use is. The next step after this has been around for a while will be to remove the deprecated APIs entirely.